Skip to content

Deploy Logical Servers API spec updates for Soft-Delete in 20240801Preview#34370

Merged
jeremyfrosti merged 2 commits intoAzure:release-sql-Microsoft.Sql-2024-08-01-previewfrom
pjpatel12:dev/jaypatel/sssr-prod-2
May 13, 2025
Merged

Deploy Logical Servers API spec updates for Soft-Delete in 20240801Preview#34370
jeremyfrosti merged 2 commits intoAzure:release-sql-Microsoft.Sql-2024-08-01-previewfrom
pjpatel12:dev/jaypatel/sssr-prod-2

Conversation

@pjpatel12
Copy link
Copy Markdown
Contributor

NOTE: This description has been copied from a previously created PR for receiving API code approval for DsMainDev.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • Need to expose swagger for two existing optional parameters. This functionality has been available via previous versions, we just did not expose the swagger previously.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app bot commented Apr 30, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app bot commented Apr 30, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-RpaaSRPNotInPrivateRepo data-plane new-api-version new-rp-namespace NotReadyForARMReview RPaaS SuppressionReviewRequired TypeSpec Authored with TypeSpec and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 1, 2025
@mikekistler mikekistler added the BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. label May 6, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed data-plane new-api-version CI-RpaaSRPNotInPrivateRepo BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview labels May 6, 2025
@jeremyfrosti
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

Copy link
Copy Markdown
Member

@rkmanda rkmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 9, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 9, 2025
@jeremyfrosti jeremyfrosti enabled auto-merge (squash) May 9, 2025 14:43
@jeremyfrosti
Copy link
Copy Markdown
Member

/pr RequestMerge

auto-merge was automatically disabled May 12, 2025 22:43

Pull request was closed

@jeremyfrosti jeremyfrosti reopened this May 12, 2025
@jeremyfrosti jeremyfrosti enabled auto-merge (squash) May 12, 2025 22:58
@msyyc
Copy link
Copy Markdown
Member

msyyc commented May 13, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@jeremyfrosti
Copy link
Copy Markdown
Member

/azp run "PoliCheck,Swagger ApiDocPreview,Swagger Avocado,Swagger BreakingChange,Swagger ModelValidation"

@azure-pipelines
Copy link
Copy Markdown

No pipelines are associated with this pull request.

@jeremyfrosti
Copy link
Copy Markdown
Member

/azp run "Swagger ModelValidation"

@azure-pipelines
Copy link
Copy Markdown

No pipelines are associated with this pull request.

@jeremyfrosti
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@jeremyfrosti jeremyfrosti merged commit ae036cf into Azure:release-sql-Microsoft.Sql-2024-08-01-preview May 13, 2025
46 of 61 checks passed
@jeremyfrosti jeremyfrosti mentioned this pull request Jul 11, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager SQL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants